Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MacOS createdump and createdump cleanup. #37224

Merged
merged 6 commits into from
Jun 3, 2020
Merged

MacOS createdump and createdump cleanup. #37224

merged 6 commits into from
Jun 3, 2020

Commits on Jun 3, 2020

  1. General createdump cleanup. 

    Converted the char* name fields (process name in CrashInfo and module name in MemoryRegion) to std::string for easier cleanup and usage.

Removed the vestiges of the SOS support (the m_sos flag, ThreadInfo::GetRegistersWithDataTarget(), etc.).

Moved the Linux read memory code out of the DataTarget into CrashInfo. DataTarget is now a thin wrapper around CrashInfo.

In the dumpwriter, fix the "number of program headers" calculate to just the ones backed by memory. Only write the memory regions backed by memory.  This makes lldb fail the memory read in these regions instead of returning zeros.

Removed the TRACE macro from the ElfReader; use the Trace() virtual method directly.
    mikem@microsoft.com committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    63ed4bd View commit details
    Browse the repository at this point in the history

  2. MacOS createdump 

    Add MachO in-memory module reader (MachOReader).

Refactor CrashInfo and ThreadInfo in Unix and MacOS versions.
    mikem@microsoft.com committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    5d34691 View commit details
    Browse the repository at this point in the history

  3. Fix build

    mikem@microsoft.com committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    0a0a70e View commit details
    Browse the repository at this point in the history

  4. Code review feedback

    mikem@microsoft.com committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    8f5b4a3 View commit details
    Browse the repository at this point in the history

  5. Enabled crash/unhandled exception createdump trigger.

    mikem@microsoft.com committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    6e1588b View commit details
    Browse the repository at this point in the history

  6. Code review feedback 

    Add unwind and eh frame info to coredump
    mikem@microsoft.com committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    49f2f49 View commit details
    Browse the repository at this point in the history