Implement hdt_get_function_pointer #37696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @vitek-karas, @swaroop-sridhar |
vitek-karas
requested changes
Jun 10, 2020
...clr/src/System.Private.CoreLib/src/Internal/Runtime/InteropServices/FunctionPointerLoader.cs
Outdated
Show resolved
Hide resolved
src/installer/corehost/cli/test/nativehost/host_context_test.cpp
Outdated
Show resolved
Hide resolved
src/installer/corehost/cli/test/nativehost/host_context_test.cpp
Outdated
Show resolved
Hide resolved
src/installer/tests/HostActivation.Tests/NativeHosting/FunctionPointerLoading.cs
Outdated
Show resolved
Hide resolved
src/installer/tests/HostActivation.Tests/NativeHosting/FunctionPointerLoading.cs
Outdated
Show resolved
Hide resolved
src/installer/tests/HostActivation.Tests/NativeHosting/FunctionPointerLoading.cs
Outdated
Show resolved
Hide resolved
|
If you don't mind, I'd like to address your feedback on the existing code first in #37784 before continuing with this PR. |
rseanhall
force-pushed
the
35465-hdt-get-function-pointer
branch
from
961b436
to
ddcae27
Compare
vitek-karas
approved these changes
Jun 15, 2020
src/installer/tests/HostActivation.Tests/NativeHosting/GetFunctionPointer.cs
Show resolved
Hide resolved
AaronRobinsonMSFT
approved these changes
Jun 15, 2020
|
Thanks a lot @rseanhall! |
|
Oh, this is just great. I wish we had this in .NET Core 3, my project would benefit a lot from it. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second half of #35465. First half was at #37473.
Closes #35465.