Fix solution restore in libraries #38294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @safern, @ViktorHofer |
|
Thanks for reporting @Anipik 👍 |
jeffkl
approved these changes
Jun 23, 2020
safern
approved these changes
Jun 23, 2020
|
I see, thanks. Would it make sense to import |
|
Probably not as the reason why msbuild introduced the Directory.Solution.* extension point was because importing Directory.Solution.* would have been a breaking change. No need for a solution to get the full msbuild context. |
|
Makes sense. Just wondering what we needed to import and share on both kind of environments. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37358
VS doesn't honor the
RestoreUseStaticGraphEvaluationset in a Directory.Build.props import as that file isn't imported in a solution. Specifying the property in aDirectory.Solution.propsfile which is imported in a solution uses static graph restore and fixes the restore issue.