Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase delays in flaky tests #38444

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Increase delays in flaky tests #38444

merged 1 commit into from
Jun 29, 2020

Conversation

alnikola
Copy link
Contributor

Two tests are failing due to delays being too small for background actions completion when test VM perf degrades. PR increases those delays.

@alnikola alnikola added test-bug Problem in test source code (most likely) test-run-core Test failures in .NET Core test runs labels Jun 26, 2020
@alnikola alnikola requested a review from a team June 26, 2020 14:22
@alnikola
Copy link
Contributor Author

/azp run runtime-libraries outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

ManickaP
ManickaP approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will lead to longer test execution, if we're OK with it, I'm as well.

@ManickaP
Copy link
Member

I'm trying to fix this test failure in this PR: #38453.
So feel free to merge against it, it is unrelated.

@ghost
Copy link

ghost commented Jun 26, 2020

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

@alnikola alnikola merged commit 9972b7b into dotnet:master Jun 29, 2020
@alnikola alnikola deleted the alnikola/2020-06-24-fix-new-failed-tests branch June 29, 2020 10:10
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ManickaP ManickaP ManickaP approved these changes

Assignees
No one assigned
Labels
area-System.Net.Http test-bug Problem in test source code (most likely) test-run-core Test failures in .NET Core test runs
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@alnikola @ManickaP @karelz @Dotnet-GitSync-Bot