-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove BundleDir/PublishDir at the end of ArchiveTests to save disk space #39714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hosted build agents have not a lot of free disk space and since we don't need the OutDir anymore after we created the test archive we can delete it.
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @safern, @ViktorHofer |
safern
approved these changes
Jul 21, 2020
ViktorHofer
approved these changes
Jul 21, 2020
…pi.Tests.csproj Adding the project reference will no longer work since we're deleting the OutDir of the other project when it is archived. Instead reference the necessary source files directly.
ViktorHofer
reviewed
Jul 21, 2020
...e.Xml/tests/Xslt/XslCompiledTransformApi/System.Xml.Xsl.XslCompiledTransformApi.Tests.csproj
Show resolved
Hide resolved
akoeplinger
changed the title
Remove OutDir at the end of ArchiveTests to save disk space
Remove BundleDir/PublishDir at the end of ArchiveTests to save disk space
Jul 22, 2020
ViktorHofer
approved these changes
Jul 22, 2020
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
…pace (dotnet#39714) Hosted build agents have not a lot of free disk space and since we don't need these dirs anymore after we created the test archive we can delete it.
ghost
locked as resolved and limited conversation to collaborators
Dec 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hosted build agents have not a lot of free disk space and since we don't need these dirs anymore after we created the test archive we can delete it.