-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT: ensure fgFirstBB has appropriate flags #40038
Conversation
This fixes an issue where release jits might sometimes generate bad GC info. Keeping it minimal for now so we can consider servicing preview 8. See dotnet#39023 for details.
@BruceForstall PTAL Don't expect codegen diffs, will run SPMI in rel/rel mode to see if it spots any GC info diffs. |
Arm build failure looks spurious:
|
No release-release SPMI diffs on tests.pmi.Windows_NT.x64.Release.mch, or on the sample code I had from #39023. Not surprising -- it is unclear how often / how many methods might be affected by this, and SPMI might alter the odds. |
Format patch file is empty, no changes when I reformat locally. |
formatting: #40034 |
Pretty sure all these failures are unrelated. |
Port of dotnet#40038 to Preview 8. Fix dotnet#39023 Release jits might sometimes generate bad GC info. Mysterious intermittent crashes. Without this fix jit GC info generation for some methods is non-deterministically bad. Yes, problem does not occur in 3.1. Very low.
This fixes an issue where release jits might sometimes generate bad GC info. Keeping it minimal for now so we can consider servicing preview 8. See dotnet#39023 for details.
This fixes an issue where release jits might sometimes generate bad GC info.
Keeping it minimal for now so we can consider servicing preview 8.
See #39023 for details.