Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: ensure fgFirstBB has appropriate flags #40038

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

AndyAyersMS
Copy link
Member

This fixes an issue where release jits might sometimes generate bad GC info.
Keeping it minimal for now so we can consider servicing preview 8.

See #39023 for details.

This fixes an issue where release jits might sometimes generate bad GC info.
Keeping it minimal for now so we can consider servicing preview 8.

See dotnet#39023 for details.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 28, 2020
@AndyAyersMS
Copy link
Member Author

@BruceForstall PTAL
cc @dotnet/jit-contrib

Don't expect codegen diffs, will run SPMI in rel/rel mode to see if it spots any GC info diffs.

@AndyAyersMS
Copy link
Member Author

Arm build failure looks spurious:

2020-07-28T19:57:03.4660344Z   Building Custom Rule F:/workspace/_work/1/s/src/coreclr/src/inc/CMakeLists.txt
2020-07-28T19:57:03.4664353Z   CMake does not need to re-run because F:/workspace/_work/1/s/artifacts/obj/coreclr/Windows_NT.arm.Checked/src/inc/CMakeFiles/generate.stamp is up-to-date.
2020-07-28T19:57:03.4988566Z MSBUILD : error MSB4017: The build stopped unexpectedly because of an unexpected logger failure.
2020-07-28T19:57:03.4990443Z Microsoft.Build.Exceptions.InternalLoggerException: The build stopped unexpectedly because of an unexpected logger failure. ---> System.ArgumentNullException: Parameter "projectProperty" cannot be null.
2020-07-28T19:57:03.4991907Z    at Microsoft.Build.Shared.ErrorUtilities.VerifyThrowArgumentNull(Object parameter, String parameterName, String resourceName)
2020-07-28T19:57:03.4993161Z    at Microsoft.Build.Collections.CopyOnWritePropertyDictionary`1.Set(T projectProperty)

@AndyAyersMS
Copy link
Member Author

No release-release SPMI diffs on tests.pmi.Windows_NT.x64.Release.mch, or on the sample code I had from #39023. Not surprising -- it is unclear how often / how many methods might be affected by this, and SPMI might alter the odds.

@AndyAyersMS
Copy link
Member Author

Format patch file is empty, no changes when I reformat locally.

@BruceForstall
Copy link
Member

formatting: #40034

@AndyAyersMS
Copy link
Member Author

Pretty sure all these failures are unrelated.

@AndyAyersMS AndyAyersMS merged commit 5c344f6 into dotnet:master Jul 29, 2020
AndyAyersMS added a commit to AndyAyersMS/runtime that referenced this pull request Jul 29, 2020
Port of dotnet#40038 to Preview 8.

Fix dotnet#39023

Release jits might sometimes generate bad GC info.

Mysterious intermittent crashes. Without this fix jit GC
info generation for some methods is non-deterministically bad.

Yes, problem does not occur in 3.1.

Very low.
danmoseley pushed a commit that referenced this pull request Jul 30, 2020
…0086)

Port of #40038 to Preview 8.

Fix #39023

Release jits might sometimes generate bad GC info.

Mysterious intermittent crashes. Without this fix jit GC
info generation for some methods is non-deterministically bad.

Yes, problem does not occur in 3.1.

Very low.
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
This fixes an issue where release jits might sometimes generate bad GC info.
Keeping it minimal for now so we can consider servicing preview 8.

See dotnet#39023 for details.
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants