Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Remove unused icalls for Environment properties #40079

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

akoeplinger
Copy link
Member

They are no longer needed after #38996 since we return values in managed code now.

They are no longer needed after dotnet#38996 since we return values in managed code now.
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Jul 29, 2020

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

@marek-safar marek-safar merged commit bb82d67 into dotnet:master Jul 29, 2020
@akoeplinger akoeplinger deleted the remove-unused-icall branch July 29, 2020 14:57
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
They are no longer needed after dotnet#38996 since we return values in managed code now.
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants