Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dotnet pack on libs src project #40107

Merged
merged 2 commits into from
Jul 30, 2020

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Jul 29, 2020

Fixes #37960

Not adding the redirection to the ref project to make the src project the single entrypoint for dotnet pack. This probably needs some documentation updates as well.

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

eng/packaging.targets Outdated Show resolved Hide resolved
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, if I do dotnet pack in a src proj, will it restore the ref and src for me?

eng/packaging.targets Show resolved Hide resolved
eng/packaging.targets Show resolved Hide resolved
@ViktorHofer
Copy link
Member Author

With this change, if I do dotnet pack in a src proj, will it restore the ref and src for me?

Yes, it will incrementally restore and build both the src project and if there's a P2P to the ref project as well, then also that one.

Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
@ViktorHofer ViktorHofer merged commit c205ed0 into dotnet:master Jul 30, 2020
@ViktorHofer ViktorHofer deleted the PackSrcProj branch July 30, 2020 07:58
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
* Support dotnet pack on libs src project

* Update eng/packaging.targets

Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support dotnet pack on libraries projects
5 participants