Increase multiple HTTP/2 connections test timeouts again #40464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alnikola
added
area-System.Net.Http
test-run-core
|
Tagging subscribers to this area: @dotnet/ncl |
geoffkizer
approved these changes
Aug 6, 2020
|
Do we know that these are just sometimes taking slightly longer, rather than them outright hanging such that no amount of additional time will be helpful? I start to wonder whenever I see "again" when discussing increasing timeouts. |
|
No evidence of this being a real hang has been found so far, but it is still possible. If it keeps reappearing after this increase, I will try investigating it further. |
|
Open / close to trigger CI. |
|
Open / close to trigger CI. |
|
Ok, it seems it doesn't work this way. |
alnikola
deleted the
alnikola/increase-multi-http2-conn-tests-timeouts-2
branch
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40115
Fixes #40436