Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block casting to an interface marked ComInterfaceType.InterfaceIsIInspectable #41633

Merged

Conversation

jkoritzinsky
Copy link
Member

During the cast path, nothing checks if an interface is an IInspectable interface. This PR adds that check to ensure that we block usage of ComInterfaceType.InterfaceIsIInspectable now that WinRT support is removed.

Fixes #41621

Signed-off-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 5.0.0 milestone Aug 31, 2020
@ghost
Copy link

ghost commented Aug 31, 2020

Hello @jkoritzinsky!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@jkoritzinsky
Copy link
Member Author

@AaronRobinsonMSFT I'm assuming we want to backport this to 5.0 once this merges into master?

@AaronRobinsonMSFT
Copy link
Member

@jkoritzinsky Bah. Boo... I forgot the main branch is now 6. It would be nice if you could try and take it to ship room. Just the product change nothing else. I really consider this a missed scenario for our WinRT in .NET 5.0 plans. It isn't blocking anyone, but shutting down all those entry points would be ideal.

/cc @jeffschwMSFT @Scottj1s

@jkoritzinsky
Copy link
Member Author

The only failure is on Mono WASM and this code only runs on Windows on CoreCLR. I'm going to merge this in.

@jkoritzinsky jkoritzinsky merged commit eb22f4e into dotnet:master Sep 1, 2020
@jkoritzinsky jkoritzinsky deleted the mngd-iinspectable-iface-block branch September 1, 2020 20:36
@jkoritzinsky jkoritzinsky restored the mngd-iinspectable-iface-block branch September 1, 2020 20:36
@jkoritzinsky
Copy link
Member Author

/backport to release/5.0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2020

Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/234983966

@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
@jkoritzinsky jkoritzinsky deleted the mngd-iinspectable-iface-block branch January 21, 2021 19:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.NET 5 removal of WinRT support does not correctly reject ComInterfaceType.InterfaceIsIInspectable
3 participants