Fix crossbuild on CentOS #43189
Merged
Fix crossbuild on CentOS #43189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the crossbuilding to work on CentOS. Clang frontend presets some of the compiler options based on the host OS and I guess that's causing the need to add the `--rpath-link`. The ranlib change to use llvm ranlib fixed a problem where cmake attempted to use ranlib from the rootfs for some reason.
|
Tagging subscribers to this area: @ViktorHofer |
janvorli
commented
Oct 8, 2020
| @@ -139,6 +139,10 @@ function(add_toolchain_linker_flag Flag) | |||
| set("CMAKE_SHARED_LINKER_FLAGS${CONFIG_SUFFIX}" "${CMAKE_SHARED_LINKER_FLAGS${CONFIG_SUFFIX}} ${Flag}" PARENT_SCOPE) | |||
| endfunction() | |||
|
|
|||
| if(CMAKE_SYSTEM_NAME STREQUAL "Linux") | |||
There was a problem hiding this comment.
I've created a PR in arcade for the change in this file, but to not to have to wait for it to propagate, I am adding it here too.
am11
reviewed
Oct 8, 2020
eng/native/configuretools.cmake
Outdated
| if(CMAKE_C_COMPILER_ID MATCHES "GNU") | ||
| locate_toolchain_exec(ranlib CMAKE_RANLIB) | ||
| else() | ||
| if(NOT CMAKE_C_COMPILER_ID MATCHES "GNU") |
There was a problem hiding this comment.
nit: we are not using NOT pattern with CMAKE_C{XX}_COMPILER_ID in other places
Suggested change
| if(NOT CMAKE_C_COMPILER_ID MATCHES "GNU") | |
| if(CMAKE_C_COMPILER_ID STREQUAL Clang) |
There was a problem hiding this comment.
Thanks for the suggestion, I've replaced it with if(CMAKE_C_COMPILER_ID MATCHES "Clang") as we use the same in the code above.
jkoritzinsky
approved these changes
Oct 9, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the crossbuilding to work on CentOS. Clang
frontend presets some of the compiler options based on the
host OS and I guess that's causing the need to add the
--rpath-link.The ranlib change to use llvm ranlib fixed a problem where
cmake attempted to use ranlib from the rootfs for some
reason.
These changes have no effect on the cross build on Ubuntu.
The reason for fixing it is that we'd like to move our cross build to
CentOS 7 from Ubuntu so that the cross tools generated during
the build can run on the same distros as natively built tools.