Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mono testing doc: testing.md #44362

Closed
wants to merge 1 commit into from
Closed

Update mono testing doc: testing.md #44362

wants to merge 1 commit into from

Conversation

fanyang-mono
Copy link
Member

No description provided.

@ghost
Copy link

ghost commented Nov 6, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

@fanyang-mono fanyang-mono mentioned this pull request Nov 6, 2020
Merged
@ViktorHofer
Copy link
Member

@maryamariyan I'm curious why "area-infrastructure-libraries" was picked? The PR title mentions mono so I would have assumed that "area-infrastructure-mono" would have been picked.

@ghost
Copy link

ghost commented Nov 6, 2020

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

@maryamariyan
Copy link
Member

maryamariyan commented Nov 6, 2020 •
edited
Loading

@ViktorHofer as explained earlier this week, this means existing PRs labeled area-Infrastructure-mono in this case have bad items in them (previous incorrect predictions never got corrected or maintained for this area).

Chatted with @jkotas on this and agreed to just not let the bot label any area-infrastructure* labels anymore starting next week. Leaving it as a manual process from now on.

@fanyang-mono
Copy link
Member Author

The content of this PR has been moved to #44360. Closing this one now.

@akoeplinger akoeplinger deleted the fanyang-mono-patch-1-1 branch November 9, 2020 10:54
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveisok steveisok Awaiting requested review from steveisok

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

Assignees
No one assigned
Labels
area-Meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fanyang-mono @ViktorHofer @maryamariyan @CoffeeFlux @Dotnet-GitSync-Bot