XmlSerializer.Serialize doesn't work when using TrimMode=link #44772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make XmlSerializer work correctly with ILLinker trimming. 1. Use constant BindingFlags to work around dotnet/linker#1617 2. Annotate CodeGenerator.CreateTypeBuilder correctly to preserve base class members Fix dotnet#41389
jkotas
reviewed
Nov 17, 2020
src/libraries/System.Private.Xml/src/System/Xml/Serialization/CodeGenerator.cs
Outdated
Show resolved
Hide resolved
joperezr
reviewed
Nov 17, 2020
src/libraries/System.Private.Xml/tests/TrimmingTests/XmlSerializer.Deserialize.cs
Show resolved
Hide resolved
Fix ILLinker suppresions.
|
@StephenMolloy @HongGit - any feedback here? |
|
Looks fine to me. Since we've been having conversations about serializer trimmailbity... @mconnew, have you had a chance to review this PR? |
|
@StephenMolloy @mconnew @HongGit - If you approve of these changes, can someone mark the PR as "approved"? I cannot merge it without an approving review. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make XmlSerializer work correctly with ILLinker trimming.
Fix #41389
cc @rolfbjarne @marek-safar