Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address ILLink warning in InteropServices.JavaScript #45727

Merged
merged 3 commits into from
Dec 9, 2020

Commits on Dec 7, 2020

  1. Address ILLink warning in InteropServices.JavaScript

    In order to make the code trimming-compatible, a slight behavior change was made. The SetupJSContinuation method will only get the Result of Task<TResult> objects. If an object derives from the base Task class, and defines its own Result property, SetupJSContinuation will no longer respect that property.
    
    This was done so the behavior remains consistent between trimmed and untrimmed applications.
    
    Contributes to dotnet#45623
    eerhardt committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    d0d5ba6 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2020

  1. Respond to PR feedback

    eerhardt committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    3764a58 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2b6e455 View commit details
    Browse the repository at this point in the history