Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a blurb on the x86 calling convention to clr-abi.md #45807

Merged
merged 4 commits into from
Dec 9, 2020
Merged

Add a blurb on the x86 calling convention to clr-abi.md #45807

merged 4 commits into from
Dec 9, 2020

Conversation

jkoritzinsky
Copy link
Member

Add some information about the x86 calling convention based on my learnings from #39294

@jkoritzinsky jkoritzinsky added documentation Documentation bug or enhancement, does not impact product or test code area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Dec 8, 2020
@jkoritzinsky jkoritzinsky added this to the 6.0.0 milestone Dec 8, 2020
sandreenko
sandreenko reviewed Dec 8, 2020
View reviewed changes
docs/design/coreclr/botr/clr-abi.md Outdated Show resolved Hide resolved
docs/design/coreclr/botr/clr-abi.md Outdated Show resolved Hide resolved
jkoritzinsky and others added 2 commits December 8, 2020 15:37
@jkoritzinsky
Update docs/design/coreclr/botr/clr-abi.md
0d42a07 
Co-authored-by: Sergey Andreenko <seandree@microsoft.com>
@jkoritzinsky
Add specific callout about how the managed and native x86 calling con…
4ffeab1 
…ventions differ.
sandreenko
sandreenko approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@sandreenko sandreenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this.

@jkoritzinsky jkoritzinsky merged commit d5a9b9d into dotnet:master Dec 9, 2020
@jkoritzinsky jkoritzinsky deleted the clr-abi-updates branch December 9, 2020 00:43
@ghost ghost locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas left review comments

@sandreenko sandreenko sandreenko approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI documentation Documentation bug or enhancement, does not impact product or test code
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jkoritzinsky @jkotas @sandreenko