Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return actual LoadLibrary failures for IJW scenarios. #45997

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Return actual LoadLibrary failures for IJW scenarios. #45997

merged 2 commits into from
Jan 5, 2021

Conversation

AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 6.0.0 milestone Dec 12, 2020
@AaronRobinsonMSFT AaronRobinsonMSFT marked this pull request as ready for review December 18, 2020 00:54
elinor-fung
elinor-fung approved these changes Jan 4, 2021
View reviewed changes
src/coreclr/vm/peimage.cpp Outdated Show resolved Hide resolved
@AaronRobinsonMSFT
Copy link
Member Author

Last change is comment update only so will skip validation.

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 0622fa0 into dotnet:master Jan 5, 2021
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the runtime45611 branch January 5, 2021 19:19
@AaronRobinsonMSFT AaronRobinsonMSFT mentioned this pull request Jan 13, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elinor-fung elinor-fung elinor-fung approved these changes

Assignees
No one assigned
Labels
area-Interop-coreclr
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

Improve the failure messaging for C++/CLI binaries that are missing dependencies
2 participants
@AaronRobinsonMSFT @elinor-fung