Backport parts of EventPipe PR 43711 not currently in C library. #46214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/CC @josalem |
|
Our systems assume issues and PR's have exactly one area-XX label. If this applies to both, does area-System.Diagnostics.Tracing work well enough? |
|
I don't think |
|
I'm fine with that, your call. If you do make one you'll need to go back and relabel older issues as appropriate so that we can retrain the bot and it can apply it. |
josalem
approved these changes
Jan 6, 2021
|
For now, I'm going to consolidate these changes under |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of missing parts from #43711 , parts of this was already fixed in EventPipe C library when initially detected and reported as and issue in C++ library.