Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove StartupHooks ILLink warning suppressions from shared file #46559

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Jan 5, 2021

One suppression is needed going forward in order for developers to get a warning if they trim apps with StartupHookProvider.IsSupported=true.

Contributes to #45623

One suppression is needed going forward in order for developers to get a warning if they trim apps with StartupHookProvider.IsSupported=true.

Contributes to dotnet#45623
@eerhardt eerhardt added area-AssemblyLoader-coreclr linkable-framework Issues associated with delivering a linker friendly framework labels Jan 5, 2021
@ghost
Copy link

ghost commented Jan 5, 2021

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF
See info in area-owners.md if you want to be subscribed.

Issue Details

One suppression is needed going forward in order for developers to get a warning if they trim apps with StartupHookProvider.IsSupported=true.

Contributes to #45623

Author: eerhardt
Assignees: -
Labels:

area-AssemblyLoader-coreclr, linkable-framework

Milestone: -

@eerhardt
Copy link
Member Author

eerhardt commented Jan 5, 2021

JIT failures are #46596. Merging.

@eerhardt eerhardt merged commit cb0e8b4 into dotnet:master Jan 5, 2021
@eerhardt eerhardt deleted the StartupHooksILLinkWarnings branch January 5, 2021 19:27
@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-AssemblyLoader-coreclr linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants