Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete reflection blocking on GetThreadDeserializationTracker #46607

Merged
merged 2 commits into from
Jan 6, 2021

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Jan 6, 2021

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@jkotas
Copy link
Member Author

jkotas commented Jan 6, 2021

This method is one of the method that seem to suffer from #45906 . @sandreenko has been hitting problems with it. Since we have agreed earlier that it is not worth it to go out of our way to protect this from private reflection, it is best to delete it to reduce differences between runtimes and reduce performance overhead of this

@jkotas jkotas merged commit 9053d5d into dotnet:master Jan 6, 2021
@jkotas jkotas deleted the reflection-block branch January 6, 2021 04:50
@BruceForstall
Copy link
Member

@jkotas I just saw:

Assert failure(PID 10008 [0x00002718], Thread: 9560 [0x2558]): Consistency check failed: No method entry found for System.Threading.Thread::GetThreadDeserializationTracker.
FAILED: 0 != id

<no module>! <no symbol> + 0x0 (0x00000000)
    File: C:\gh\runtime\src\coreclr\vm\ecall.cpp Line: 385
    Image: c:\bugs\spmi\coreroot.windows.arm.Checked\windows.arm.Checked\Tests\Core_Root\CoreRun.exe

(on Windows arm32)

Is this a Windows arm32-specific issue? OR perhaps my incremental build didn't build enough?

@jkotas
Copy link
Member Author

jkotas commented Jan 7, 2021

It looks like an incremental build problem to me.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants