Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SafeHandle types to have public parameterless constructors and add InitHandle API #47189

Merged
5 commits merged into from
Jan 20, 2021
Merged

Update SafeHandle types to have public parameterless constructors and add InitHandle API #47189

5 commits merged into from
Jan 20, 2021

Commits on Jan 19, 2021

  1. Update public SafeHandle types to have public parameterless construct… 

    …ors.

Remove now-unneeded ILLink trim files.

Make public abstract SafeHandle constructors protected.

Remove comment on SafeWaitHandle
    @jkoritzinsky
    jkoritzinsky committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    6efd06b View commit details
    Browse the repository at this point in the history

  2. Make SafeHandle constructors public for internal types. 

    Make internal abstract SafeHandle default constructors protected. Make non-abstract internal SafeHandles sealed when possible.

More internal SafeHandle types.
    @jkoritzinsky
    jkoritzinsky committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    923f6f5 View commit details
    Browse the repository at this point in the history

  3. Add new Marshal.InitHandle API. 

    Fix SetHandle accessibility

Fix test.

Use Marshal.InitHandle.
    @jkoritzinsky
    jkoritzinsky committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    7b99f90 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2021

  1. PR feedback.

    @jkoritzinsky
    jkoritzinsky committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    fcd055c View commit details
    Browse the repository at this point in the history

  2. Remove trailing whitespace.

    @jkoritzinsky
    jkoritzinsky committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    b6e77a7 View commit details
    Browse the repository at this point in the history