Gate UnsupportedEnum_TestData on Ref.Emit #49925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These types are reflection emitted and will be null without ref emit.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
jkotas
approved these changes
Mar 20, 2021
stephentoub
approved these changes
Mar 20, 2021
MichalStrehovsky
added a commit
to MichalStrehovsky/runtime
that referenced
this pull request
Mar 23, 2021
In dotnet#49925 I blindly followed the existing pattern but the existing pattern was wrong because with that we get failing tests: ``` System.InvalidOperationException : No data found for System.Tests.EnumTests.IsDefined_UnsupportedEnumType_ThrowsInvalidOperationException ```
MichalStrehovsky
added a commit
that referenced
this pull request
Mar 23, 2021
In #49925 I blindly followed the existing pattern but the existing pattern was wrong because with that we get failing tests: ``` System.InvalidOperationException : No data found for System.Tests.EnumTests.IsDefined_UnsupportedEnumType_ThrowsInvalidOperationException ```
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These types are reflection emitted and will be null without ref emit.