Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed regression caused by performance change #51032

Merged
merged 1 commit into from
Apr 10, 2021
Merged

Fixed regression caused by performance change #51032

merged 1 commit into from
Apr 10, 2021

Conversation

davidfowl
Copy link
Member

  • Pass empty array instead of null for validations

Fixes #51023

@davidfowl
Fixed regression caused by performance change
267a8c2 
- Pass empty array instead of null for validations
@ghost
Copy link

ghost commented Apr 9, 2021

Tagging subscribers to this area: @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Pass empty array instead of null for validations

Fixes #51023

Author: davidfowl
Assignees: -
Labels:

area-Extensions-Options
Milestone: -

@davidfowl davidfowl added this to the 6.0.0 milestone Apr 9, 2021
@davidfowl davidfowl merged commit 1b50f00 into main Apr 10, 2021
@jkotas jkotas deleted the davidfowl/fix-null-ref branch April 10, 2021 05:15
@maryamariyan maryamariyan mentioned this pull request May 7, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maryamariyan maryamariyan maryamariyan approved these changes

@eerhardt eerhardt Awaiting requested review from eerhardt

Assignees
No one assigned
Labels
area-Extensions-Options
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

OptionsFactory constructor should check for null validations before calling ToArray()
2 participants
@davidfowl @maryamariyan