Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issues with caching in the wrong slot #52168

Merged
merged 2 commits into from
May 3, 2021
Merged

Fixed issues with caching in the wrong slot #52168

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd38d9e
Fixed issues with caching in the wrong slot
davidfowl May 2, 2021
dcbd4f4
Only catch AggregateExceptions
davidfowl May 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Only catch AggregateExceptions 
- Those are the ones that ValidateOnBuild throws
  • Loading branch information
@davidfowl
davidfowl committed May 2, 2021
commit dcbd4f4915e69b842d47a47ee33cd9f9a293b02d
2 changes: 1 addition & 1 deletion ...ons.DependencyInjection/tests/DI.Tests/ServiceProviderDefaultContainerTestsWithOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ protected override IServiceProvider CreateServiceProvider(IServiceCollection col
// ValidateScopes = true
});
}
catch
catch (AggregateException)
{
// This is how we "skip" tests that fail on BuildServiceProvider (broken object graphs).
// We care mainly about exercising the non-throwing code path so we fallback to the default BuildServiceProvider
Expand Down