-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One Shot ECB #52510
Merged
Merged
One Shot ECB #52510
Changes from 35 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
4e831fd
ECB decrypt skeleton
vcsjones 0192aeb
Add AES ECB decrypt one-shot
vcsjones 3648777
Simple test
vcsjones ba0391e
Add ECB decrypt tests
vcsjones 21e3760
Decrypt in to buffer unless no padding
vcsjones 7505b6a
Implement ECB encryption
vcsjones ef12105
Add more ECB encrypt tests
vcsjones 7a808fd
Add tests for zero length buffers
vcsjones 835cf76
Fixup ECB tests
vcsjones 7a72745
Add 3DES and tests.
vcsjones 425f6c8
Implement DES ECB
vcsjones 5fd05ca
Implement RC2 one shot
vcsjones b205986
Fix overlapping buffers in CNG
vcsjones 0768841
Allow-list one shot ECB for not overridding
vcsjones bf32394
Permit overlapping buffers on MacOS
vcsjones 5993181
Get non-persisted keys working for CNG one shots
vcsjones 7d0ea8d
Fix padding calculation for CNG types.
vcsjones 9dbd999
Fix overlapping buffer check on CNG.
vcsjones a853ccd
AES/3DES persisted CNG key implementation and tests
vcsjones 1df32b7
Fix indentation
vcsjones 720018b
Fix white space
vcsjones b32fd8a
Merge remote-tracking branch 'ms/main' into 2406-one-shot-ecb
vcsjones b1c6ea3
Some code review feedback and WIP on documentation.
vcsjones 02d68cb
Merge remote-tracking branch 'upstream/main' into 2406-one-shot-ecb
vcsjones ccdecda
Fix build
vcsjones 500b829
Fix compilation, again
vcsjones 2d43ec7
Remove reset. This does not hold over any cipher data
vcsjones 3f0c165
Use pool for decrypt buffer
vcsjones 16ff27f
Add missing empty line.
vcsjones b315f93
Fix whitespace
vcsjones 03b5564
Finish XML documentation
vcsjones 1ebb11c
Fixup exceptions
vcsjones 23fe2a6
Fix handling core implementation that indicates it wrote more bytes
vcsjones 1c65eec
Test and fix for overflow
vcsjones f20f7aa
Merge remote-tracking branch 'ms/main' into 2406-one-shot-ecb
vcsjones 0d76e80
Fix grammar and punctuation
vcsjones 33c649d
Remove unnecessary early return.
vcsjones 0e3b568
Let Array.Resize do the work of creating a new array
vcsjones d017f9d
Simplify throwing exceptions for incorrect encryption length
vcsjones 18f2478
Apply feedback consistently
vcsjones File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to take the block size parameter separately and get rid of the algorithm/this parameter? Then nothing could sneak its way in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably; I wanted to clean this all up a bit when I get to the CFB implementation. There's a bit of weirdness of so many things being passed around... some of it is in bits, some of it is in bytes...