Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Span<T>.Fill implementation for Array.Fill #52590

Merged
merged 16 commits into from
Jun 30, 2021
Merged

Use Span<T>.Fill implementation for Array.Fill #52590

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
bb1d2ee
Optimise `Array.Fill` implementation
xtqqczze May 11, 2021
d6577fc
Use `Array.Fill` rather then calling `AsSpan().Fill`
xtqqczze May 11, 2021
41d5b9a
Fix unecessary sign extension
xtqqczze May 11, 2021
a851f05
Optimise argument validation with `uint`
xtqqczze May 11, 2021
f261e92
Add array variance checks
xtqqczze May 12, 2021
07dd088
Use `Span(T[]? array)` ctor
xtqqczze May 13, 2021
a2cf547
Add casting tests
xtqqczze May 13, 2021
f6fee90
fixup! 07dd088911a
xtqqczze Jun 18, 2021
8c90687
Add additional tests
xtqqczze Jun 18, 2021
5168dab
remove try/catch
xtqqczze Jun 18, 2021
535878e
remove `Enumerable.Repeat`
xtqqczze Jun 19, 2021
80b950b
separate tests
xtqqczze Jun 19, 2021
c48c69c
Fix CS1503
xtqqczze Jun 22, 2021
f2cfecd
Revert "Fix CS1503"
xtqqczze Jun 24, 2021
c718716
Fix `Assert.Equal`
xtqqczze Jun 24, 2021
015e50f
Implement `IEquatable<Bar>`
xtqqczze Jun 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove try/catch
  • Loading branch information
@xtqqczze
xtqqczze committed Jun 18, 2021
commit 5168dabf9c7b467dfc3c173f8ac2f78b9c28a713
24 changes: 3 additions & 21 deletions src/libraries/System.Runtime/tests/System/ArrayTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4298,29 +4298,11 @@ public static void Fill_Casting_Invalid()
{
Bar[] barArray1 = CreateBarArray();
Assert.Throws<ArrayTypeMismatchException>(() => Array.Fill<object>(barArray1, new Foo()));
Assert.Equal(CreateBarArray(), barArray1);

Bar[] barArray2 = CreateBarArray();
try
{
Array.Fill<object>(barArray2, new Foo());
}
catch (ArrayTypeMismatchException)
{
Assert.Equal(CreateBarArray(), barArray2);
}

Bar[] barArray3 = CreateBarArray();
Assert.Throws<ArrayTypeMismatchException>(() => Array.Fill<object>(barArray3, new Foo(), 1, 2));

Bar[] barArray4 = CreateBarArray();
try
{
Array.Fill<object>(barArray4, new Foo(), 1, 2);
}
catch (ArrayTypeMismatchException)
{
Assert.Equal(CreateBarArray(), barArray4);
}
Assert.Throws<ArrayTypeMismatchException>(() => Array.Fill<object>(barArray2, new Foo(), 1, 2));
Assert.Equal(CreateBarArray(), barArray2);
}

public static IEnumerable<object[]> Reverse_Generic_Int_TestData()
Expand Down