Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire diagnostic source events from IHostBuilder.Build #53757

Merged
merged 17 commits into from
Jun 8, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Increase the timeout
  • Loading branch information
davidfowl committed Jun 7, 2021
commit 12ae4e99273821e6354ef635ef2882ee334b70f4
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ private class DeferredHostBuilder : IHostBuilder, IObserver<DiagnosticListener>,
private Action<IHostBuilder> _configure;

// The amount of time we wait for the diagnostic source events to fire
private static readonly TimeSpan _waitTimeout = TimeSpan.FromSeconds(5);
private static readonly TimeSpan _waitTimeout = TimeSpan.FromSeconds(20);
davidfowl marked this conversation as resolved.
Show resolved Hide resolved

public DeferredHostBuilder(string[] args, MethodInfo entryPoint)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public void CreateHostBuilderPattern__Invalid_CantFindHostBuilder()
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(CreateHostBuilderInvalidSignature.Program))]
public void CreateHostBuilderPattern__Invalid_CantFindServiceProvider()
{
RemoteExecutor.Invoke(() =>
using var _ = RemoteExecutor.Invoke(() =>
{
var factory = HostFactoryResolver.ResolveServiceProviderFactory(typeof(CreateHostBuilderInvalidSignature.Program).Assembly);

Expand All @@ -140,7 +140,7 @@ public void CreateHostBuilderPattern__Invalid_CantFindServiceProvider()
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(NoSpecialEntryPointPattern.Program))]
public void NoSpecialEntryPointPattern()
{
RemoteExecutor.Invoke(() =>
using var _ = RemoteExecutor.Invoke(() =>
{
var factory = HostFactoryResolver.ResolveServiceProviderFactory(typeof(NoSpecialEntryPointPattern.Program).Assembly);

Expand All @@ -153,7 +153,7 @@ public void NoSpecialEntryPointPattern()
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(NoSpecialEntryPointPatternThrows.Program))]
public void NoSpecialEntryPointPatternThrows()
{
RemoteExecutor.Invoke(() =>
using var _ = RemoteExecutor.Invoke(() =>
{
var factory = HostFactoryResolver.ResolveServiceProviderFactory(typeof(NoSpecialEntryPointPatternThrows.Program).Assembly);

Expand All @@ -166,7 +166,7 @@ public void NoSpecialEntryPointPatternThrows()
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(NoSpecialEntryPointPatternExits.Program))]
public void NoSpecialEntryPointPatternExits()
{
RemoteExecutor.Invoke(() =>
using var _ = RemoteExecutor.Invoke(() =>
{
var factory = HostFactoryResolver.ResolveServiceProviderFactory(typeof(NoSpecialEntryPointPatternExits.Program).Assembly);

Expand All @@ -179,7 +179,7 @@ public void NoSpecialEntryPointPatternExits()
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(NoSpecialEntryPointPatternHangs.Program))]
public void NoSpecialEntryPointPatternHangs()
{
RemoteExecutor.Invoke(() =>
using var _ = RemoteExecutor.Invoke(() =>
{
var factory = HostFactoryResolver.ResolveServiceProviderFactory(typeof(NoSpecialEntryPointPatternHangs.Program).Assembly);

Expand All @@ -192,7 +192,7 @@ public void NoSpecialEntryPointPatternHangs()
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(NoSpecialEntryPointPatternMainNoArgs.Program))]
public void NoSpecialEntryPointPatternMainNoArgs()
{
RemoteExecutor.Invoke(() =>
using var _ = RemoteExecutor.Invoke(() =>
{
var factory = HostFactoryResolver.ResolveServiceProviderFactory(typeof(NoSpecialEntryPointPatternMainNoArgs.Program).Assembly);

Expand All @@ -204,7 +204,7 @@ public void NoSpecialEntryPointPatternMainNoArgs()
[ConditionalFact(nameof(RequirementsMet))]
public void TopLevelStatements()
{
RemoteExecutor.Invoke(() =>
using var _ = RemoteExecutor.Invoke(() =>
{
var assembly = Assembly.Load("TopLevelStatements");
var factory = HostFactoryResolver.ResolveServiceProviderFactory(assembly);
Expand Down