Add more renegotiate tests #54609
Merged
Add more renegotiate tests #54609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue DetailsWe disallow App data frame during renegotiation. Adding test to cover this scenario.
|
wfurt
reviewed
Jun 24, 2021
| clientOptions.LocalCertificateSelectionCallback = (sender, targetHost, localCertificates, remoteCertificate, acceptableIssuers) => | ||
| { | ||
| //Assert.True(false, "Clent shouldn't send certificate in this test"); | ||
| return clientCertificate; |
There was a problem hiding this comment.
do we even need the client certificate?
| SslServerAuthenticationOptions serverOptions = new SslServerAuthenticationOptions() { ServerCertificate = serverCertificate }; | ||
| serverOptions.RemoteCertificateValidationCallback = (sender, certificate, chain, sslPolicyErrors) => | ||
| { | ||
| //Assert.True(false, "Server shouldn't receive certificate in this test"); |
There was a problem hiding this comment.
Do we even need the callback. It seems like we assert null certificate bellow.
|
seems like the failures are in the new tests. You should investigate @aik-jahoda |
wfurt
reviewed
Jun 26, 2021
|
|
||
| Assert.Null(server.RemoteCertificate); | ||
|
|
||
| Console.WriteLine("AA " + server.SslProtocol); |
There was a problem hiding this comment.
If anything, you should use _output.WriteLineI(). That would show up on test failure as well as it would be captured in testResults.xml
aik-jahoda
force-pushed
the
jajajhoda/tlsrenegotests
branch
from
9cc6f06
to
4d31737
Compare
|
Merge with failures, those are unrelated to this PR |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We disallow App data frame during renegotiation. Adding test to cover this scenario.