[interp] Don't cprop between vt vars of different sizes #54734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @BrzVlad Issue DetailsVia unsafe code, getting the lower Vector128 from a Vector256 ends up as a move of
|
vargaz
approved these changes
Jun 25, 2021
vargaz
reviewed
Jun 25, 2021
BrzVlad
force-pushed
the
fix-interp-vt-cprop
branch
from
61a27ff
to
1c45ac7
Compare
Via unsafe code, getting the lower Vector128 from a Vector256 ends up as a move of `sizeof (Vector128)` from a Vector256 var. However, the destination var is not a valid copy of the source var, having a different type
BrzVlad
force-pushed
the
fix-interp-vt-cprop
branch
from
1c45ac7
to
ec74be5
Compare
BrzVlad
added a commit
to BrzVlad/runtime
that referenced
this pull request
Jul 1, 2021
BrzVlad
added a commit
that referenced
this pull request
Jul 7, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via unsafe code, getting the lower Vector128 from a Vector256 ends up as a move of
sizeof (Vector128)from a Vector256 var. However, the destination var is not a valid copy of the source var, having a different type.