Swap using the provided indexes #55331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwapElements is passed two indexes, however, it ignored the second index and instead used `index + 1`. It just so happened that the caller used `index + 1` as the second index, but that might not have been the case.
|
|
|
This looks like a formatting error - I checked and followed the instructions in the build log but couldn't find the patch in the artifacts. Nor could I run the formatter locally. Can someone point me at the formatting artifact that I need to fix this, thanks! |
terrajobst
added
the
community-contribution
|
Closing/reopening to kick-off CI again on latest main |
|
@stephentoub this appears to be ok to merge? |
It looks fine to me, but I avoided merging it figuring the owner of this code might want to weigh in. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwapElements is passed two indexes, however, it ignored the second index and instead used
index + 1. It just so happened that the caller usesindex + 1as the second index (as a result, this change should not change any behaviour) but that might not have been the case and the code is clearly wrong here.