Revert recent update of a docker image in eng/common #56540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change (if it was really needed) should be made in the arcade repo as this file is regularly updated from there. However, I can see that the change I am reverting was not really needed as the docker image is meant for managed stuff only and so it doesn't need to be updated to the new version that added the LLD linker.
|
Tagging subscribers to this area: @hoyosjs Issue DetailsThis change (if it was really needed) should be made in the arcade repo as this
|
|
fyi: @am11 |
jkoritzinsky
approved these changes
Jul 29, 2021
|
LGTM but I think bumping the image in arcade is still a good idea so we don't use an image from 2019 |
stephentoub
approved these changes
Jul 30, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change (if it was really needed) should be made in the arcade repo as this
file is regularly updated from there. However, I can see that the change I am
reverting was not really needed as the docker image is meant for managed stuff
only and so it doesn't need to be updated to the new version that added the
LLD linker.