Remove old fwlink from Obsolete messages and make message improvements #56690
Conversation
…tween ref and src
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
.../System.Runtime.InteropServices/src/System/Runtime/InteropServices/IDispatchImplAttribute.cs
Outdated
Show resolved
Hide resolved
...s/Microsoft.Extensions.Hosting.Abstractions/ref/Microsoft.Extensions.Hosting.Abstractions.cs
Outdated
Show resolved
Hide resolved
|
@danmoseley Would you mind reviewing this? (I believe @jkotas is unavailable to re-review this week). |
| @@ -507,13 +507,13 @@ private bool SetApartmentState(ApartmentState state, bool throwOnError) | |||
| return SetApartmentStateUnchecked(state, throwOnError); | |||
| } | |||
|
|
|||
| [Obsolete("Thread.GetCompressedStack is no longer supported. Please use the System.Threading.CompressedStack class")] | |||
| [Obsolete("Thread.GetCompressedStack has been deprecated. Use the System.Threading.CompressedStack class instead.")] | |||
There was a problem hiding this comment.
This should rather be [System.ObsoleteAttribute("Code Access Security is not supported or honored by the runtime.", DiagnosticId = "SYSLIB0003", UrlFormat = "https://aka.ms/dotnet-warnings/{0}")]
Same for SetCompressedStack and System.Threading.CompressedStack
There was a problem hiding this comment.
Oh, cool. It will be a very minor breaking change to switch the diagnostic ID, but I think it's appropriate here, as any usage of CAS would already need to be accommodated in the build.
I'll make that change as a separate PR so that we have an isolated breaking change.
...aries/System.Runtime.InteropServices/src/System/Runtime/InteropServices/IDispatchImplType.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/Threading/ThreadPool.CoreCLR.cs
Outdated
Show resolved
Hide resolved
|
The failing checks are infrastructure / networking issues and are unrelated. |
ghost
locked as resolved and limited conversation to collaborators
Fixes #47255.
Removes from all messages the unhelpful fwlink that points to a "What's obsolete in the .NET Framework class library" page.
Takes a pass through all
[Obsolete]APIs and makes the messages more consistent throughout.Does not attempt to utilize the new
UrlFormatproperty on theObsoleteattribute, as we don't have dedicated diagnostic IDs or landing pages for the affected APIs. Spot-checking the APIs with web searches was resulting in good hits in our docs and other sites.