make use of ports in SPN optional #57159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThis is regression caused by #40860. There is some ambiguity of port should be use for contracting SPN when it is not default. We did not do that up to 5.0 and we do since. However that change can have negative impact on existing services. I did some more testing with IIS can 4.7/4.8 It seems like when configure server on custom ports, client connects to it without specifying port in SPN.
|
stephentoub
reviewed
Aug 10, 2021
...raries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/AuthenticationHelper.NtAuth.cs
Show resolved
Hide resolved
stephentoub
reviewed
Aug 10, 2021
...raries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/AuthenticationHelper.NtAuth.cs
Outdated
Show resolved
Hide resolved
…andler/AuthenticationHelper.NtAuth.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
|
@stephentoub do the latest changes address all your feedback? Once we have CR, we should be able to merge. |
stephentoub
approved these changes
Aug 16, 2021
thaystg
added a commit
to thaystg/runtime
that referenced
this pull request
Aug 16, 2021
…information # By dotnet-maestro[bot] (4) and others # Via GitHub * origin/main: (58 commits) Localized file check-in by OneLocBuild Task (dotnet#57384) [debugger][wasm] Support DebuggerProxyAttribute (dotnet#56872) Account for type mismatch of `FIELD_LIST` members in LSRA (dotnet#57450) Qualify `sorted_table` allocation with `nothrow` (dotnet#57467) Rename transport packages to follow convention (dotnet#57504) Generate proper DWARF reg num for ARM32 (dotnet#57443) Enable System.Linq.Queryable and disable dotnet#50712 (dotnet#57464) Mark individual tests for 51211 (dotnet#57463) Fix Length for ReadOnlySequence created out of sliced Memory owned by MemoryManager (dotnet#57479) Add JsonConverter.Write/ReadAsPropertyName APIs (dotnet#57302) Remove workaround for dotnet/sdk#19482 (dotnet#57453) Do not drain HttpContentReadStream if the connection is disposed (dotnet#57287) [mono] Fix a few corner case overflow operations (dotnet#57407) make use of ports in SPN optional (dotnet#57159) Fixed H/3 stress server after the last Kestrel change (dotnet#57356) disable a failing stress test. (dotnet#57473) Eliminate temporary byte array allocations in the static constructor of `IPAddress`. (dotnet#57397) Update dependencies from https://github.com/dotnet/emsdk build 20210815.1 (dotnet#57447) [main] Update dependencies from mono/linker (dotnet#57344) Improve serializer performance (dotnet#57327) ... # Conflicts: # src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs # src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs # src/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs
karelz
added
the
breaking-change
ghost
added
the
needs-breaking-change-doc-created
|
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
|
Marking as breaking change as it is technically breaking against 5.0 (bring back 3.1 and earlier behavior). |
ezsilmar
pushed a commit
to criteo-forks/runtime
that referenced
this pull request
Sep 16, 2021
* make port optional in SPN * fix tests * feedback from review * Update src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/AuthenticationHelper.NtAuth.cs Co-authored-by: Stephen Toub <stoub@microsoft.com> * fix build Co-authored-by: Stephen Toub <stoub@microsoft.com> Conflicts: src/libraries/Common/tests/System/Net/EnterpriseTests/EnterpriseTestConfiguration.cs src/libraries/Common/tests/System/Net/EnterpriseTests/setup/apacheweb/apache2.conf src/libraries/Common/tests/System/Net/EnterpriseTests/setup/apacheweb/run.sh src/libraries/Common/tests/System/Net/EnterpriseTests/setup/docker-compose.yml src/libraries/System.Net.Http/tests/EnterpriseTests/HttpClientAuthenticationTest.cs
ghost
locked as resolved and limited conversation to collaborators
wfurt
removed
the
needs-breaking-change-doc-created
|
Breaking change issue created: dotnet/docs#26603 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is regression caused by #40860. There is some ambiguity if port should be used for contracting SPN when it is not default port. We did not do that up to 5.0 and we do since. However that change can have negative impact on existing services.
Since there is no API for developers to control the SPN (#25320), I added ENV & AppContext switch so control this and choose old or new behavior globally.
I did some more testing with IIS can 4.7/4.8 It seems like when configure server on custom ports, client connects to it without specifying port in SPN.
For that reason I'm leaving this off by default as we did prior to 5.0.
fixes #53193
fixes #51701