Try to fix and enable a ThreadPool.CompletedWorkItemCount test and add more info about failures #57240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kouvel
commented
Aug 11, 2021
•
kouvel
commented
- Not sure why it would be failing. The test seems to be calling a different sub-test method than intended. Fixed that and added more info if it happens to fail again.
- Closes ThreadPoolBoundHandleTests.MultipleOperationsOverSingleHandle_CompletedWorkItemCountTest timed out #47979
- Closes MultipleOperationsOverSingleHandle_CompletedWorkItemCountTest frequent failures #49700
…d more info about failures - Not sure why it would be failing. The test seems to be calling a different sub-test method than intended. Fixed that, updated the test to use a different temp file name in case the two relevant tests run in parallel, and added more info if it happens to fail again. - Closes dotnet#47979 - Closes dotnet#49700
|
Tagging subscribers to this area: @mangod9 Issue Details
|
danmoseley
reviewed
Aug 12, 2021
src/libraries/System.Threading.Overlapped/tests/ThreadPoolBoundHandle_IntegrationTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Aug 17, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.