-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][debugger] Proxy but don't process events from worker sessions #57974
Conversation
Tagging subscribers to this area: @thaystg |
9477974
to
cc94e1c
Compare
Isn't the same check needed for |
Not exactly, those don't expect the context to exist in the same way: |
What are the "worker sessions" mentioned in the title? Are these sessions executing while the mono runtime is also executing? If so, then couldn't we receive this message for a non-mono session? Looking at the code, it's handling two mono [1][2] specific cases, so it won't be a problem with that, IIUC. But if we can receive messages not meant for us, then it might still be a good idea to check in that case, and proxy the message? |
https://developer.mozilla.org/en-US/docs/Web/API/Worker
I'm not sure I follow? In the cases where it isn't from mono it does get proxied. |
/backport to release/6.0-rc1 |
Started backporting to release/6.0-rc1: https://github.com/dotnet/runtime/actions/runs/1160816690 |
Should Fix #57949
@thaystg can you see if you can construct a test for this?