roll r2r jobs into crossgen2-outerloop #58282
Conversation
| - windows_x64 | ||
| - windows_arm64 | ||
| - windows_arm | ||
| - CoreClrTestBuildHost # Either OSX_x64 or Linux_x64 | ||
| jobParameters: | ||
| testGroup: outerloop |
There was a problem hiding this comment.
Is building Release required here? Looks like its used in comparison jobs, but can that use Checked instead?
There was a problem hiding this comment.
If the comparison legs work fine in checked build mode, I don't see why we'd need to build release just because of them.
There was a problem hiding this comment.
will update in a subsequent PR. @davidwrighton any specific reason comparison jobs require Release builds?
| - windows_x64 | ||
| - windows_arm64 | ||
| - windows_arm | ||
| - CoreClrTestBuildHost # Either OSX_x64 or Linux_x64 | ||
| jobParameters: | ||
| testGroup: outerloop |
There was a problem hiding this comment.
If the comparison legs work fine in checked build mode, I don't see why we'd need to build release just because of them.
There was a problem hiding this comment.
You need to remove the # Limited outerloop testing in non-composite mode comment, right?
Are you going to adjust the schedule to be daily, like r2r.yml?
There is still cg2 R2R testing in "outerloop" (ci.yml), that is batch run. Should you remove any testing here that is already done in ci.yml? (Is there any overlap?) Presumably, we do want that batch test R2R testing preferably to this daily "cg2 outerloop" testing.
I'm not sure we need to test on Windows arm(32). We do minimal testing in outerloop to keep it alive, but it is not supported. Maybe it's still useful to keep it alive for R2R?
It might be possible/easier to use platformGroup: all instead of listing all the platforms; I'm not sure if your platform set is equivalent to that (but note that platformGroup: all includes windows_arm).
|
yeah makes sense to remove arm, though I copied the it over from r2r. Will get that removed. Will check ci.yml as to what is run there. Some duplication is ok unless its easy to separate. |
ghost
locked as resolved and limited conversation to collaborators
With crossgen1 now defunct merging R2R and crossgen2 outerloops runs into a single CI. This should help with reducing duplication of CI runs.
Contributes to #58120