Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve overload ambiguities from lambda expression inference change #58953

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

cston
Copy link
Member

@cston cston commented Sep 10, 2021

Resolve overload ambiguities resulting from C#10 compiler changes to inference with lambda expressions.

See #58873 (comment)

cc @stephentoub

@ghost
Copy link

ghost commented Sep 10, 2021

Tagging subscribers to this area: @tarekgh, @dotnet/area-system-linq-parallel
See info in area-owners.md if you want to be subscribed.

Issue Details

Resolve overload ambiguities resulting from C#10 compiler changes to inference with lambda expressions.

See #58873 (comment)

cc @stephentoub

Author: cston
Assignees: -
Labels:

area-System.Linq.Parallel

Milestone: -

@cston
Copy link
Member Author

cston commented Sep 10, 2021

cc @ericstj, @ViktorHofer

@CyrusNajmabadi
Copy link
Member

I would prefer we not take this, and we first see what we can do in the language to make these retain their original meaning.

@AlekseyTs
Copy link
Contributor

Resolve overload ambiguities resulting from C#10 compiler changes to inference with lambda expressions.

Is there a spec or description of how the ambiguities are supposed to be resolved?

@cston
Copy link
Member Author

cston commented Sep 10, 2021

I would prefer we not take this, and we first see what we can do in the language to make these retain their original meaning.

We can revert this change later if the C# compiler is updated to no longer report these cases as ambiguous. In the meantime, this change, or something similar, is needed to allow moving to the latest compiler.

@stephentoub
Copy link
Member

stephentoub commented Sep 10, 2021

In the meantime, this change, or something similar, is needed to allow moving to the latest compiler.

The test changes themselves look fine.

@ericstj
Copy link
Member

ericstj commented Sep 10, 2021

agree with @cston, halting codeflow is bad as it allows changes to accumulate. I've been waiting on arcade flow since Monday (due to an assortment of issues), let's please get it unblocked. File an issue, with a nice repro and use this as a test case for that fix.

@cston cston merged commit 84c6051 into dotnet:main Sep 10, 2021
@cston cston deleted the lambda-ambiguities branch September 10, 2021 20:22
@ghost ghost locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants