Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Disable partial generic sharing for gparams with non-enum constraints. #59437

Merged
merged 1 commit into from
Nov 14, 2021

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Sep 21, 2021

No description provided.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@vargaz vargaz added the arch-wasm WebAssembly architecture label Sep 22, 2021
@ghost
Copy link

ghost commented Sep 22, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: vargaz
Assignees: -
Labels:

arch-wasm

Milestone: -

@lewing
Copy link
Member

lewing commented Sep 23, 2021

@vargaz failures look potentially related

@vargaz vargaz added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 24, 2021
…traints.

If a generic argument is a primitive type, and it has an interface constraint
that enums don't implement, then partial sharing for that instance is not
useful, since only the specific primitive type instance will be able
to use the shared version.

Fixes dotnet#54910.
@vargaz vargaz removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Nov 13, 2021
@vargaz
Copy link
Contributor Author

vargaz commented Nov 13, 2021

There are no more failures, either they got fixed, or the failing lane was disabled:
runtime (Mono llvmfullaot Pri0 Runtime Tests Run Linux arm64 release)

@lewing
Copy link
Member

lewing commented Nov 14, 2021

cc @steveisok for test data

@steveisok
Copy link
Member

We should merge and let the runtime tests run on the rolling build.

@vargaz vargaz merged commit edd6467 into dotnet:main Nov 14, 2021
@vargaz vargaz deleted the gshared-enum-constraint branch November 14, 2021 02:31
@am11
Copy link
Member

am11 commented Nov 14, 2021

There are no more failures, either they got fixed, or the failing lane was disabled

This is because tests are disabled, opened: #61564. :)

@ghost ghost locked as resolved and limited conversation to collaborators Dec 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Codegen-JIT-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants