[release/6.0] [wasm] Fix typedef for non-void interp entry callbacks #59990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
For UnmanagedCallersOnly methods that return non-void, pass the address of the return variable to the interp entry method.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
/cc @lewing |
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsBackport of #59968 to release/6.0 /cc @lambdageek Customer ImpactTestingRisk
|
lambdageek
added
area-Interop-mono
Servicing-consider
|
Approved in email |
lambdageek
added
Servicing-approved
lambdageek
approved these changes
Oct 15, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #59968 to release/6.0
/cc @lambdageek
Customer Impact
Interop with C code compiled for WebAssembly is new in .NET 6.
This PR fixes an issue with "reverse-P/Invokes" (managed methods that are passed as callbacks to C code) that have a non-
voidreturn type. The stubs generated for interop between native code and the interpreter were generated with the wrong type and failed during native compilation and linking. The stubs for callbacks withvoidreturn types are not affected.Without this PR, one possible workaround is to compile the generated pinvoke header with fewer C compiler warnings turned on.
Testing
CI
Risk
Low. This is a new scenario - interop code on wasm is new code. A possible workaround is to write wrapper methods that pass an out-arg and have a
voidreturn type.