Remove xunit-performance dependency in tests #60711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue Detailsnull
|
We use BenchmarkDotNet in the dotnet/performance repo for benchmarking now. These copies of the benchmarks are for correctness testing, and for ease of debugging.
BruceForstall
force-pushed
the
RemoveXunitPerformanceTags
branch
from
a222afd
to
aac158e
Compare
BruceForstall
changed the title
|
@dotnet/jit-contrib PTAL |
This was referenced Oct 21, 2021
|
Anyone? The test failures are all unrelated. |
echesakov
approved these changes
Oct 22, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of xunit-performance is deprecated; benchmarking now happens in the dotnet/performance repo using BenchmarkDotNet. Remove all the usage of xunit-performance in the runtime tests. This means removing all the
[Benchmark]cases in the JIT benchmarks. Note that most or all of the JIT benchmarks in theruntimetree also have very similar copies in the dotnet/performance tree. The ones in theruntimetree are used for both correctness validation as well as easy of debugging.The second commit makes the
runtimecopies compare more easily with thedotnet/performancecopies; it makes them more similar. Note that there are still significant differences in a few of the implementations, notably Span/Indexer, Bytemark, and regex-redux.