Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional steps in gcc validation leg #61241

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

am11
Copy link
Member

@am11 am11 commented Nov 5, 2021

Before:
2021-10-25_573x417_scrot

After:
2021-10-25_573x417_scrot

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 5, 2021
@ghost
Copy link

ghost commented Nov 5, 2021

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: am11
Assignees: -
Labels:

area-Infrastructure-coreclr, community-contribution

Milestone: -

@am11 am11 force-pushed the feature/ci/gcc branch 2 times, most recently from dc53d15 to d433ce8 Compare November 5, 2021 05:41
@am11 am11 marked this pull request as ready for review November 5, 2021 07:09
@am11
Copy link
Member Author

am11 commented Nov 5, 2021

cc @safern, @akoeplinger, @lambdageek, perhaps this hybrid approach is not elegant in terms of code; placing non-coreclr steps in coreclr/templates/build-job.yml, but this is the minimal change to append a few "native" steps to the existing build validation leg (which was added to protect the build with GNU toolchain). Note that we do not publish artifacts anywhere from this leg.

@jkoritzinsky
Copy link
Member

@am11 since the compiler support is wired up through the root build script, I’d suggest using the global-build-job template instead and pass in a subset argument for all the native subsets and the property to set the native compiler. That will probably be much easier to maintain over time.

@am11 am11 force-pushed the feature/ci/gcc branch 5 times, most recently from 43355b3 to 83855d6 Compare November 5, 2021 11:13
@am11 am11 force-pushed the feature/ci/gcc branch 3 times, most recently from c54ebe1 to 22542c5 Compare November 6, 2021 06:53
@am11
Copy link
Member Author

am11 commented Nov 6, 2021

I am keeping the step in coreclr script for now as it is a minimal change. We have similar steps in that file.

That will probably be much easier to maintain over time.

Probably, but lets do the refactoring in a separate PR.

Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use the global-build-job template as @jkoritzinsky suggested, it will be cleaner and easier to maintain long term.

@akoeplinger akoeplinger merged commit 057e34d into dotnet:main Nov 9, 2021
@am11 am11 deleted the feature/ci/gcc branch November 9, 2021 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants