Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RIDs for MIRACLE LINUX 8 and 9 #61304

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Add RIDs for MIRACLE LINUX 8 and 9 #61304

merged 1 commit into from
Mar 4, 2022

Conversation

m10k
Copy link
Contributor

@m10k m10k commented Nov 8, 2021

Whenever we build dotnet RPMs for MIRACLE LINUX 8 (formerly Asianux Server 8) we have to
apply patches that add RIDs for MIRACLE LINUX. To streamline the build process, we would
like to add our RIDs to the upstream sources, in the same way CentOS and other RHEL-
derivatives do.

This commit adds the following runtime IDs:

  • "miraclelinux"
  • "miraclelinux-x64"
  • "miraclelinux.8"
  • "miraclelinux.8-x64"
  • "miraclelinux.9"
  • "miraclelinux.9-x64"

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 8, 2021
@ghost
Copy link

ghost commented Nov 8, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Whenever we build dotnet RPMs for MIRACLE LINUX 8 (formerly Asianux Server 8) we have to
apply patches that add RIDs for MIRACLE LINUX. To streamline the build process, we would
like to add our RIDs to the upstream sources, in the same way CentOS and other RHEL-
derivatives do.

This commit adds the following runtime IDs:

  • "miraclelinux"
  • "miraclelinux-x64"
  • "miraclelinux.8"
  • "miraclelinux.8-x64"
Author: m10k
Assignees: -
Labels:

area-Infrastructure-libraries, community-contribution

Milestone: -

@dnfadmin
Copy link

dnfadmin commented Nov 8, 2021

CLA assistant check
All CLA requirements met.

@wfurt
Copy link
Member

wfurt commented Nov 8, 2021

seems like you either miss some file @m10k or something else change. The failure is clearly related to your change and something is out of sync.

@m10k
Copy link
Contributor Author

m10k commented Nov 9, 2021

I have looked at the PRs that added RIDs for other distributions (Alpine 3.14 #55857, Debian 11 #56789, Fedora 36 #57832), and they don't seem any different. Since this PR adds a new distro, not just a new version of an existing distro, are there other files that need to be modified?

@safern
Copy link
Member

safern commented Nov 12, 2021

@m10k you want to add it to this file as well: https://github.com/dotnet/runtime/blob/ec15b53daa184583ef978dfd59e30ca4791e9470/src/libraries/Microsoft.NETCore.Platforms/src/runtimeGroups.props

Here is an example of a new platform addition: ec15b53

@m10k
Copy link
Contributor Author

m10k commented Nov 15, 2021

@safern Thanks for the feedback! I had already added Miracle Linux to runtimeGroups.props, so that doesn't seem to be the issue. The PR for Rocky Linux introduced some other changes that I don't have in my PR, but they are not necessary for Miracle Linux, because on ML we don't have the minor version in /etc/os-release's VERSION_ID.

As far as I can tell, the issue is that the RID graph needs to be rebuilt (/p:UpdateRuntimeFiles=true needs to be passed), which is is something we also have to do when building dotnet on our buildserver - I don't know how I would do that here though.

@safern
Copy link
Member

safern commented Nov 15, 2021

Ah I see, then you have to run the build with /p:UpdateRuntimeFiles=true and then commit whatever changed into this PR.

Whenever we build dotnet RPMs for MIRACLE LINUX 8 (formerly Asianux Server 8) we have to
apply patches that add RIDs for MIRACLE LINUX. To streamline the build process, we would
like to add our RIDs to the upstream sources, in the same way CentOS and other RHEL-
derivatives do.

This commit adds the following runtime IDs:
 - "miraclelinux"
 - "miraclelinux-x64"
 - "miraclelinux.8"
 - "miraclelinux.8-x64"
 - "miraclelinux.9"
 - "miraclelinux.9-x64"
@m10k m10k changed the title Add RIDs for MIRACLE LINUX 8 Add RIDs for MIRACLE LINUX 8 and 9 Feb 16, 2022
@m10k
Copy link
Contributor Author

m10k commented Feb 16, 2022

Sorry, it took me quite a while to follow up.. I'm not sure but I have the feeling it was the newline at the end of the files that caused the tests to fail.
Either way, there are still some failing tests, but they seem unrelated to this change. Do I see that right?

Also, I took the opportunity to add ML9 as well.

@m10k m10k requested a review from omajid February 17, 2022 06:58
@bartonjs
Copy link
Member

Seems OK to me (and CI is happy now). Any other comments, @wfurt?

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericstj ericstj merged commit d24bd73 into dotnet:main Mar 4, 2022
@m10k
Copy link
Contributor Author

m10k commented Mar 4, 2022

Awesome, thank you everyone!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Host community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants