[wasm] Reduce the output from tests. #61593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
maraf
commented
Nov 15, 2021
maraf
commented
- Do not printout exceptions from failing task tests.
- Remove default MONO_LOG_MASK=gc from debug configuration.
- Do not printout exceptions from failing task tests. - Remove default MONO_LOG_MASK=gc from debug configuration.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
pavelsavara
approved these changes
Nov 15, 2021
This was referenced Nov 29, 2021
lewing
reviewed
Nov 30, 2021
| // Setting this env var allows Diagnostic.Debug to write to stderr. In a browser environment this | ||
| // output will be sent to the console. Right now this is the only way to emit debug logging from | ||
| // corlib assemblies. | ||
| monoeg_g_setenv ("COMPlus_DebugWriteToStdErr", "1", 0); | ||
| // monoeg_g_setenv ("COMPlus_DebugWriteToStdErr", "1", 0); |
There was a problem hiding this comment.
I wonder if we should revisit the way this works and send Debug.* output to the proper js console
There was a problem hiding this comment.
Just for reference this is what it does
This was referenced Nov 30, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.