Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR #60054: add Windows.Server.Core.20H2 #62253

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Revert PR #60054: add Windows.Server.Core.20H2 #62253

merged 1 commit into from
Dec 2, 2021

Conversation

agocke
Copy link
Member

@agocke agocke commented Dec 1, 2021

This reverts commit efc8adb.

It looks like we have a number of test failures on Server.20H2, see #62205

Those tests will need to either be disabled or fixed before we enable this testing

@ghost
Copy link

ghost commented Dec 1, 2021

Tagging subscribers to this area: @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

This reverts commit efc8adb.

It looks like we have a number of test failures on Server.Core.20H2, see #62205

Those tests will need to either be disabled or fixed before we enable this testing

Author: agocke
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@@ -132,11 +132,9 @@ jobs:
- Windows.81.Amd64.Open
- Windows.10.Amd64.ServerRS5.Open
- Windows.10.Amd64.Server19H1.Open
- Windows.10.Amd64.Server20H2.Open
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is not Server Core, are these failures happening on this SKU as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, sorry, these are in 20H2 non-Core, typo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@safern Anything else?

@agocke
Copy link
Member Author

agocke commented Dec 2, 2021

Confirmed in https://dev.azure.com/dnceng/public/_build/results?buildId=1493013&view=results that this passes the runtime leg

@agocke
Copy link
Member Author

agocke commented Dec 2, 2021

@ericstj mind signing off on this so we can unblock the build?

Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we tracking reenabling the whole queue? The linked issue is a single test.

@agocke
Copy link
Member Author

agocke commented Dec 2, 2021

@hoyosjs Do you have a preference on re-using the existing issue on the test failures vs. opening a new issue?

@agocke agocke merged commit 87d156b into main Dec 2, 2021
@agocke agocke deleted the revert-60054 branch December 2, 2021 03:35
@agocke
Copy link
Member Author

agocke commented Dec 2, 2021

Actually there's already an issue for this, #57947, which was missing a 20H2 entry, which I added

@hoyosjs
Copy link
Member

hoyosjs commented Dec 2, 2021

@agocke I think of them as disjoint - one tracks enabling testing on the platform, the other one tracks a flaky test on that platform. Is this the only test we've observed with this behavior?

@agocke
Copy link
Member Author

agocke commented Dec 2, 2021

I think dealing with failing tests is part of enabling the new platform. Either they need to be skipped and a bug filed, or the tests need to be fixed during bring-up. Either way, probably involves the product team.

@safern
Copy link
Member

safern commented Dec 2, 2021

This will get easier once I add the new pipeline to separate what goes into rolling only and into PR 😄

@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants