Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move 1604 docker based helix queues to 1804 #62871

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Move 1604 docker based helix queues to 1804 #62871

merged 1 commit into from
Dec 16, 2021

Conversation

safern
Copy link
Member

@safern safern commented Dec 15, 2021

No description provided.

@safern safern requested review from MattGal and a team December 15, 2021 23:54
@ghost ghost assigned safern Dec 15, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Dec 15, 2021

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: safern
Assignees: safern
Labels:

area-Infrastructure
Milestone: -

MattGal
MattGal approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@MattGal MattGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nit I kind of prefer making everything lower cased but it's case insensitive :)

@safern
Copy link
Member Author

safern commented Dec 16, 2021

minor nit I kind of prefer making everything lower cased but it's case insensitive :)

I'll leave it as is since the majority of queues are declared as camel case.

@safern safern merged commit fe1f92e into main Dec 16, 2021
@safern safern deleted the MoveDockerQueues1804 branch December 16, 2021 17:01
@ghost ghost locked as resolved and limited conversation to collaborators Jan 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@MattGal MattGal MattGal approved these changes

Assignees

@safern safern

Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@safern @jkoritzinsky @MattGal