Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] improve memory access and marshaling range checks #64845

Merged
merged 13 commits into from
May 20, 2022
Merged

[wasm] improve memory access and marshaling range checks #64845

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d119e50
* new memory accessors setI52, setI64Big, getI52, getI64Big
pavelsavara May 13, 2022
a9a8bcc
doc
pavelsavara May 13, 2022
e6c06c4
tests
pavelsavara May 16, 2022
27cf6b8
feedback from @kg
pavelsavara May 16, 2022
b6f033c
fix
pavelsavara May 16, 2022
4547c85
Merge branch 'main' into wasm_resize_and_int64
pavelsavara May 19, 2022
5b5e6b5
- made assert silent on Release config
pavelsavara May 19, 2022
7982e54
- fixed marshaling of uint32, uint16 and byte to be unsigned
pavelsavara May 19, 2022
3e20335
inlined asserts
pavelsavara May 19, 2022
3e3e658
fix test
pavelsavara May 19, 2022
a11bcf3
fix message
pavelsavara May 19, 2022
067e9db
optimize inline
pavelsavara May 19, 2022
7b2e211
rename mono_assert and make sure we replace them all
pavelsavara May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test
  • Loading branch information
@pavelsavara
pavelsavara committed May 19, 2022
commit 3e3e658b4f0a7a71c69beeaa5735dfbca23f4799
2 changes: 1 addition & 1 deletion ...InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/MemoryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public static unsafe void UInt52TestOK(ulong value)
if (value < int.MaxValue)
{
Assert.IsType<int>(o);
ulong actual = (uint)o;
ulong actual = (ulong)(long)(int)o;
Assert.Equal(expected, actual);
}
Assert.Equal(expected, actual2);
Expand Down
1 change: 0 additions & 1 deletion src/mono/wasm/runtime/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

import { bind_runtime_method } from "./method-binding";
import { CharPtr, EmscriptenModule, ManagedPointer, NativePointer, VoidPtr } from "./types/emscripten";
import Configuration from "consts:configuration";

export type GCHandle = {
__brand: "GCHandle"
Expand Down