Enable Mariner 2.0 DEPS package #65442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
approved these changes
Feb 16, 2022
am11
reviewed
Feb 16, 2022
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <LinuxPackageDependency Include="openssl-libs;icu;krb5" /> |
There was a problem hiding this comment.
Q: do we need libnuma? It is a soft (!required) dependency, but some functionality in coreclr takes advantage of it for scaling / multi-processor scenarios (@janvorli, please correct me if that's not the case).
There was a problem hiding this comment.
Q: do we need libnuma? It is a soft (!required) dependency, but some functionality in coreclr takes advantage of it for scaling / multi-processor scenarios (@janvorli, please correct me if that's not the case).
We can update this later. For now, we'd like to use the same set of dependencies as Mariner 1.0.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #65441
Enables Mariner 2.0 DEPS package.
Contributes to end-to-end solution for: #64756