Ensure all expected paths are logged on test failure #65666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsitnik
added
area-System.IO
test-enhancement
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsThe failure provided in #65601 is not very helpful: Let's print all information in the exception message so we can move on with #65601 diagnostics.
|
ghost
assigned 
stephentoub
reviewed
Feb 22, 2022
src/libraries/System.IO.FileSystem.Watcher/tests/Utility/FileSystemWatcherTest.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Feb 22, 2022
| } | ||
| catch (Exception ex) | ||
| { | ||
| _output?.WriteLine(ex.ToString()); |
There was a problem hiding this comment.
These were saving the exception information out to the log file. That's not useful anymore?
There was a problem hiding this comment.
Based on the information provided in #65601 I don't think it's useful:
Not found: /var/folders/62/ftpn5pv523j8xsdw56s9jnp40000gs/T/Directory_Create_Tests_hsm4w3hg.os4/FileSystemWatcher_Directory_Create_InNestedDirectory_53_bb03705a/dir1
In value: String[] ["/var/folders/62/ftpn5pv523j8xsdw56s9jnp40000gs/T/D"...]
Since the exception was re-thrown anyway I don't see any benefits of keeping this logic. Am I missing something?
stephentoub
approved these changes
Feb 22, 2022
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failure provided in #65601 is not very helpful:
Let's print all information in the exception message so we can move on with #65601 diagnostics.