Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[debugger] First draft of managed debugger on wasi #67272

Merged
merged 68 commits into from
Aug 12, 2022
Merged

[debugger] First draft of managed debugger on wasi #67272

merged 68 commits into from
Aug 12, 2022

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented Mar 28, 2022 •
edited
Loading

Screencast from 28-03-2022 20_26_16

Still waiting for this fix to make it work using official wastime:
bytecodealliance/wasmtime#3936
I fixed locally to implement the PR and test it.

Debugger.Break(), Breakpoints, Stepping, Locals, Expressions and CallStack are working correctly.

@ghost ghost assigned thaystg Mar 28, 2022
@ghost
Copy link

ghost commented Mar 28, 2022

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Screencast from 28-03-2022 20_26_16

Still waiting for this fix to make it work using official wastime:
bytecodealliance/wasmtime#3936
I fixed locally to implement the PR and test it.

Stepping is not working yet.
Debugger.Break(), Breakpoints, Locals, Expressions and CallStack are working correctly.

Author: thaystg
Assignees: thaystg
Labels:

area-Debugger-mono
Milestone: -

@thaystg thaystg changed the title [debugger] First draft of debug wasi [debugger] First draft of managed debugger on wasi Mar 28, 2022
@SteveSandersonMS
Copy link
Member

This is awesome! Super glad to see this!

@thaystg
Copy link
Member Author

thaystg commented Mar 29, 2022

Screencast from 29-03-2022 13_43_16

@sdeleuze sdeleuze mentioned this pull request Apr 11, 2022
Open
@ghost ghost added the no-recent-activity label Apr 15, 2022
@ghost
Copy link

ghost commented Apr 15, 2022

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

@ghost ghost added the no-recent-activity label May 2, 2022
@ghost
Copy link

ghost commented May 2, 2022

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

@radical
Copy link
Member

radical commented Aug 8, 2022

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@radical
Copy link
Member

radical commented Aug 8, 2022

/azp run runtime, runtime-staging,runtime-dev-innerloop,dotnet-linker-tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

radical
radical approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats, and excellent job!!

@radical
Copy link
Member

radical commented Aug 10, 2022

The wasm failure is known, and can be ignored.

@radical radical mentioned this pull request Aug 10, 2022
Closed
@radical
Copy link
Member

radical commented Aug 10, 2022

And the NativeAOT failure is #73698 .

@SteveSandersonMS
Copy link
Member

Awesome, great job with this @thaystg!

@thaystg thaystg merged commit 3db2ebf into dotnet:main Aug 12, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viniciusjarina viniciusjarina viniciusjarina left review comments

@SteveSandersonMS SteveSandersonMS SteveSandersonMS left review comments

@radical radical radical approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@vargaz vargaz Awaiting requested review from vargaz

@lambdageek lambdageek Awaiting requested review from lambdageek lambdageek is a code owner

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

@BrzVlad BrzVlad Awaiting requested review from BrzVlad BrzVlad is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

Assignees

@thaystg thaystg

Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@thaystg @SteveSandersonMS @lewing @radical @viniciusjarina @BrzVlad