Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Narrow cast fix #70518

Merged
merged 13 commits into from
Jun 16, 2022
Merged

Narrow cast fix #70518

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2256487
Added genActualTypeSize. Remove narrow cast if the actual type sizes …
TIHan Jun 9, 2022
dafa0bb
Trying to fix build
TIHan Jun 9, 2022
11836ac
Fixing build
TIHan Jun 10, 2022
8e56f46
Removed genActualTypeSize. Using genActualType instead
TIHan Jun 10, 2022
2c6b216
Added helper function
TIHan Jun 11, 2022
813d13b
Comments
TIHan Jun 11, 2022
a952ab9
Moving back to morph
TIHan Jun 13, 2022
1e00d6b
Merge remote-tracking branch 'upstream/main' into narrow-cast-fix
TIHan Jun 13, 2022
5215fea
Removing part of the test
TIHan Jun 13, 2022
367612c
Added fgOptimizeCastOnAssignment
TIHan Jun 13, 2022
9926179
Fixing build
TIHan Jun 13, 2022
234aeed
Removing extra bits
TIHan Jun 14, 2022
ad543ad
Removed fgIsSafeToRemoveIntToIntCastOnAssignment, inlining the implem…
TIHan Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixing build
  • Loading branch information
@TIHan
TIHan committed Jun 13, 2022
commit 9926179b3805bb97e2c9ce27700227f871fd3d0e
6 changes: 3 additions & 3 deletions src/coreclr/jit/flowgraph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,13 +752,13 @@ bool Compiler::fgIsSafeToRemoveIntToIntCastOnAssignment(GenTree* tree)
if (gtIsActiveCSE_Candidate(cast->CastOp()))
return false;

if (!varTypeIsIntegral(castToType))
if (!varTypeIsSmall(effectiveOp1))
return false;

if (!varTypeIsIntegral(castFromType))
if (!varTypeIsSmall(castToType))
return false;

if (!varTypeIsIntegral(effectiveOp1))
if (!varTypeIsIntegral(castFromType))
TIHan marked this conversation as resolved.
Show resolved Hide resolved
return false;

// If we are performing a narrowing cast and
Expand Down