Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Model string literal objects as invariant and non-GLOB_REF #70986

Merged
merged 2 commits into from
Jun 20, 2022
Merged

JIT: Model string literal objects as invariant and non-GLOB_REF #70986

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
885b6b0
Model string literals as invariant/non GLOB_REF
jakobbotsch Jun 20, 2022
9411437
String literals are never null
jakobbotsch Jun 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/coreclr/jit/gentree.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6873,8 +6873,10 @@ GenTree* Compiler::gtNewStringLiteralNode(InfoAccessType iat, void* pValue)
tree = gtNewOperNode(GT_IND, TYP_REF, tree);
// This indirection won't cause an exception.
tree->gtFlags |= GTF_IND_NONFAULTING;
// This indirection points into the gloabal heap (it is String Object)
tree->gtFlags |= GTF_GLOB_REF;
// String literal objects are also ok to model as invariant.
tree->gtFlags |= GTF_IND_INVARIANT;
// ..and they are never null.
tree->gtFlags |= GTF_IND_NONNULL;
break;

default:
Expand Down